Add specs for debug info output#3476
Closed
ggiraldez wants to merge 3 commits intocrystal-lang:masterfrom
Closed
Conversation
Code originally taken from waj@da7e88b and modified to compile with the current version and improve failure messages.
ggiraldez
force-pushed
the
debug/spec-with-gdb
branch
from
4217e27 to
9a6d48b
Compare
Member
|
Would be super cool to start running tests on debug output, could we get this PR updated? |
Collaborator
|
I had forgotten this pull request. It's great! If someone can fix the failing tests, we should merge this! |
RX14
force-pushed
the
debug/spec-with-gdb
branch
4 times, most recently
from
d8b2b64 to
9b1cb48
Compare
Member
|
This is a great low hanging fruit 😮 |
Member
|
@sdogruyol I continuted this in #4718. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code originally taken from
waj@da7e88b
and modified to compile with the current version and improve failure
messages.