Fix: AArch64 context switch #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fiber context switch fails on AArch64 with a SIGBUS error. It's caused by the stack being incorrectly aligned. Pushing any other register to th stack fixes the issue. It's also impossible to read a pointer value directly into the SP register, so this patch avoids the pointer for the second argument altogether. The same could be applied for all platforms.
firejox
pushed a commit
to firejox/crystal
that referenced
this pull request
Dec 12, 2016
Fiber context switch fails on AArch64 with a SIGBUS error. It's caused by the stack being incorrectly aligned. Pushing any other register to th stack fixes the issue. It's also impossible to read a pointer value directly into the SP register, so this patch avoids the pointer for the second argument altogether. The same could be applied for all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiber context switch fails on AArch64 with a SIGBUS error. It's caused by the stack being incorrectly aligned. Pushing any other register to th stack fixes the issue.
It's also impossible to read a pointer value directly into the SP register, so this patch avoids the pointer for the second argument altogether. The same could be applied for all platforms.