Compiler: emit simpler debug info for code generated by macros #3960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes what's mentioned in this comment
I chose to expand locations that are inside macro expansions to the location where the macro is expanded, for debug info. That means that for this code:
the debug info for all the contents of the expansion of
foo
will be at the line wherefoo
is invoked (here, filename "foo.cr", line 7, column 1).A more correct solution to this, which is removed in this PR, is to generate temporary files for each macro expansion, and use that temporary file name in the debug info. The problems with this approach are:
I also copy this comment I left in the code:
We can leave a better solution for this problem, if the need arrives, for later. For now it's better to have faster compile times than to be able to debug code produced by macros.
/cc @ysbaddaden