Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes specs broken on BSD #4781

Merged
merged 1 commit into from Aug 3, 2017
Merged

Conversation

wmoxam
Copy link
Contributor

@wmoxam wmoxam commented Aug 3, 2017

Fixes: #4780

@akzhan
Copy link
Contributor

akzhan commented Aug 3, 2017

LGTM.

It follows code (hw.ncpu).

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Aug 3, 2017

Thank you!

@ysbaddaden ysbaddaden merged commit 890ab45 into crystal-lang:master Aug 3, 2017
2 checks passed
@straight-shoota
Copy link
Member

straight-shoota commented Aug 3, 2017

I mean this looks fine and is simple enough, but what about the two man rule?
Apart from that, milestone and perhaps labels are missing.

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Aug 3, 2017

I can't set milestones nor labels them on mobile :(

@matiasgarciaisaia matiasgarciaisaia added this to the Next milestone Aug 3, 2017
@wmoxam wmoxam deleted the fix-openbsd-specs branch Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants