New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML/Time parsers/formatters now take in care nanoseconds #5070
Merged
RX14
merged 6 commits into
crystal-lang:master
from
akzhan:time-constructor=now-expect-nanoseconds-instead-of-milliseconds
Oct 5, 2017
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3f781ef
YAML/Time parsers/formatters now take in care nanoseconds.
akzhan 7880992
Describe N format specifier for nanoseconds.
akzhan 52a6d14
Merge branch 'master' into time-constructor=now-expect-nanoseconds-in…
akzhan fe1c973
fix merge conflict (@Sija)
akzhan ae19379
fix spec
akzhan 1d060b8
Spec for %N format specifier.
akzhan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,13 +75,13 @@ struct YAML::Schema::Core::TimeParser | |
return new_time(year, month, day, hour, minute, second) | ||
end | ||
|
||
millisecond = 0 | ||
nanosecond = 0 | ||
|
||
if current_char == '.' | ||
next_char | ||
|
||
millisecond = parse_milliseconds | ||
return nil unless millisecond | ||
nanosecond = parse_nanoseconds | ||
return nil unless nanosecond | ||
end | ||
|
||
skip_space | ||
|
@@ -109,22 +109,22 @@ struct YAML::Schema::Core::TimeParser | |
|
||
return nil if @reader.has_next? | ||
|
||
time = new_time(year, month, day, hour, minute, second, nanosecond: millisecond * 1_000_000) | ||
time = new_time(year, month, day, hour, minute, second, nanosecond) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be |
||
if time && tz_offset | ||
time = time - tz_offset.minutes | ||
end | ||
time | ||
end | ||
|
||
def parse_milliseconds | ||
def parse_nanoseconds | ||
return nil unless current_char.ascii_number? | ||
|
||
multiplier = 100 | ||
multiplier = Time::NANOSECONDS_PER_SECOND / 10 | ||
number = current_char.to_i | ||
|
||
next_char | ||
|
||
2.times do | ||
8.times do | ||
break unless current_char.ascii_number? | ||
|
||
number *= 10 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a need for 64 bit integer here. You should use
consume_number
. It will still read 12 digits.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Int64
later. Less conversions needed.consume_number
is justconsume_number_i64.to_i
.