Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve URI implementation #6323

Merged
merged 13 commits into from Apr 5, 2019
Merged

Refactor and improve URI implementation #6323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c488efe
Refactor URI#path to be non-nilable
straight-shoota Jan 7, 2019
6bedaf9
Refactor URI::Parser removing obsolete step macro
straight-shoota Jul 3, 2018
6af4fcf
Refactor URI spec simplifying spec examples
straight-shoota Jul 3, 2018
a208c72
Fix URI#to_s to always print port when set
straight-shoota Jan 7, 2019
2aac648
Remove URI#opaque
straight-shoota Aug 15, 2018
2257692
Refactor and add URI specs
straight-shoota Jul 3, 2018
173619c
Change URI.parse to downcase scheme
straight-shoota Jul 3, 2018
dddfa6c
Fix host with escape sequences in URI.parse/URI#to_s
straight-shoota Jul 3, 2018
e6cc855
Fix URI.parse with empty port
straight-shoota Jul 3, 2018
a05296a
Fix URI.parse triple slash path
straight-shoota Jul 3, 2018
1c6a617
Fix URI#to_s path starting with `/`
straight-shoota Jul 3, 2018
7e74b84
Add return types to URI methods
straight-shoota Aug 19, 2018
b9acfe7
Refactor URI::Parser making helper methods private
straight-shoota Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions spec/std/http/request_spec.cr
View file
Open in desktop
Expand Up @@ -230,8 +230,7 @@ module HTTP
end

it "falls back to /" do
request = Request.new("GET", "/foo")
request.path = nil
request = Request.new("GET", "")
request.path.should eq("/")
end
end
Expand Down
272 changes: 0 additions & 272 deletions spec/std/uri/uri_parser_spec.cr
View file
Open in desktop

This file was deleted.