Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check presence of named argument via external name #6560

Merged

Conversation

asterite
Copy link
Member

Fixes #6559

It seems the bug was always there but it became apparent when we changed the way def foo(@abstract) and similar constructs with keywords changed their implementation.

@bcardiff bcardiff added this to the 0.26.1 milestone Aug 18, 2018
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 👍

@ysbaddaden ysbaddaden merged commit d37fdff into crystal-lang:master Aug 19, 2018
@j8r
Copy link
Contributor

j8r commented Aug 19, 2018

@RX14 won't be happy @ysbaddaden, labels are missing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants