Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal::Macros::ClassDef API #6679

Closed
wants to merge 1 commit into from

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Sep 7, 2018

Adds missing methods to Crystal::Macros::ClassDef API.

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you but this is wrong, these methods are not defined for ClassDef, only for TypeNode. You'll need to add code to implement these methods in src/compiler/crystal/macro/methods.cr

@Sija
Copy link
Contributor Author

Sija commented Sep 10, 2018

@asterite that's weird, I got impression of such properties from

class ClassDef < ASTNode
property name : Path
property body : ASTNode
property superclass : ASTNode?
property type_vars : Array(String)?
property name_column_number : Int32
property doc : String?
property splat_index : Int32?
property? abstract : Bool
property? struct : Bool
property visibility = Visibility::Public

@asterite
Copy link
Member

@Sija those are the properties, yes, but they are exposed in the file ai mentioned.

@straight-shoota straight-shoota added kind:docs topic:stdlib:macros pr:needs-work A PR requires modifications by the author. labels Feb 15, 2019
@Sija
Copy link
Contributor Author

Sija commented Oct 30, 2020

I ain't gonna finish this, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:docs pr:needs-work A PR requires modifications by the author. topic:stdlib:macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants