Fix YAML::Schema::FailSafe.parse and parse_all and add specs #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r00ster91 would you mind adding a minimal spec to stress that path? |
wooster0
changed the title
[0] instead of first? in YAMLs cast_document method
bcardiff
approved these changes
Sep 24, 2018
RX14
approved these changes
Sep 25, 2018
|
Looks OK, this regression was probably from making |
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
…-lang#6790) * Fix cast_document * Add specs and fix parse_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6786
Currently both
YAML::Schema::FailSafe.parseandYAML::Schema::FailSafe.parse_allraise errors even if correct arguments are given.In
parseusingfirst?probably used to work but doesn't work anymore. So[0]?is now used instead.At
parse_allthe wrong return type is specified. It must beArray(Any).This also adds a new file called
fail_safe_spec.crwith specs forparseandparse_all.