New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscores in the String passed to Big* constructors #7107

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@Sija
Copy link
Contributor

Sija commented Nov 23, 2018

Fixes #7106

@RX14

RX14 approved these changes Nov 24, 2018

@RX14

This comment has been minimized.

Copy link
Member

RX14 commented Nov 24, 2018

What about all the other Big types?

@Sija Sija force-pushed the Sija:fix-7106 branch from bfbf9ea to d8ff994 Nov 24, 2018

@Sija

This comment has been minimized.

Copy link
Contributor Author

Sija commented Nov 24, 2018

@RX14 good point, fixed.

@Sija Sija changed the title Strip underscores from the String passed to BigInt constructor Allow underscores in the String passed to Big* constructors Nov 24, 2018

@RX14

RX14 approved these changes Nov 24, 2018

@Sija

This comment has been minimized.

Copy link
Contributor Author

Sija commented Nov 26, 2018

Anything left to do here || gtg? 🚢

@bcardiff bcardiff added this to the 0.27.1 milestone Nov 26, 2018

@bcardiff bcardiff merged commit 1ce9161 into crystal-lang:master Nov 26, 2018

4 checks passed

ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment