Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow underscores in the String passed to Big* constructors #7107

Merged
merged 1 commit into from Nov 26, 2018
Merged

Allow underscores in the String passed to Big* constructors #7107

merged 1 commit into from Nov 26, 2018

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Nov 23, 2018

Fixes #7106

@Sija Sija mentioned this pull request Nov 23, 2018
Closed
@RX14
Copy link
Contributor

RX14 commented Nov 24, 2018

What about all the other Big types?

@Sija
Copy link
Contributor Author

Sija commented Nov 24, 2018

@RX14 good point, fixed.

@Sija Sija changed the title Strip underscores from the String passed to BigInt constructor Allow underscores in the String passed to Big* constructors Nov 24, 2018
@Sija
Copy link
Contributor Author

Sija commented Nov 26, 2018

Anything left to do here || gtg? 🚢

@bcardiff bcardiff added this to the 0.27.1 milestone Nov 26, 2018
@bcardiff bcardiff merged commit 1ce9161 into crystal-lang:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sija @RX14 @asterite @bcardiff