Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: give proper error when trying to access instance variable of union type #7194

Merged

Conversation

asterite
Copy link
Member

Fixes #7187

Eventually we can consider supporting this if all union types define that instance variable, though it would be a new kind of dispatch. Right now I don't want to spend more time on this so at least giving a proper error is better than printing "BUG".

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 👍

@RX14 RX14 added this to the 0.27.1 milestone Dec 17, 2018
@RX14 RX14 merged commit d60f89a into crystal-lang:master Dec 17, 2018
@asterite asterite deleted the bug/7187-union-not-instance-var-container branch March 30, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants