Converting between JSON and YAML #7232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Dec 29, 2018
ysbaddaden
approved these changes
Dec 29, 2018
RX14
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
YAML::Any#to_json(builder)andJSON::Any#to_yaml(builder)to convert arbitrary data between both formats.There are many uses cases for such a conversion, one example is storing arbitrary YAML input data in a database using a JSON type.
The conversion can almost entirely be implemented by delegating to
raw.to_yaml(builder)and this is works quite nicely out of the box.Since YAML is a superset of JSON,
JSON::Any#to_yamlis always valid and fully reversible.All YAML raw types except
Bytesimplement both#to_yamland#to_json, so it's not a huge issue.I've implemted Serializing
YAML::Any#to_jsonso that it raises when raw is aSlice.We could also consider serializing
Bytesas Base64 encoded string like in YAML.JSON serializes some data types which are distinct in YAML, such as
Timeas strings, thus converting from YAML to JSON is not fully reversible.