Fix corruption of thread linked list #8196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new thread finishes very quickly it could happen that the removal from the linked list was executed before the push. The linked list didn't check for that situation and it ends corrupted.
bcardiff
approved these changes
Sep 17, 2019
asterite
approved these changes
Sep 17, 2019
|
A comment about this: it looks like a simple PR but it took days to find out the cause. The work these fixes take isn't related to the code change size at all! |
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
When a new thread finishes very quickly it could happen that the removal from the linked list was executed before the push. The linked list didn't check for that situation and it ends corrupted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new thread finishes very quickly it could happen that the removal from the linked list was executed before the push. The linked list didn't check for that situation and it ends corrupted.
This is what was causing errors while the GC runs on the specs. There are some tests that create new threads with an almost empty body.
Fixes #8184