Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: use virtual type for `uninitialized` #8221

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@asterite
Copy link
Member

commented Sep 24, 2019

Fixes #8216

The issue was that uninitialized T would get a type T instead of T+ if T had subtypes. Then pointerof would get a type that didn't match the expected virtual type.

@bcardiff This should probably go into 0.31.1

@asterite

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

I'll also send a PR to refactor Channel to not use tuples, but in a separate PR.

@asterite asterite added this to the 0.31.1 milestone Sep 25, 2019
@asterite asterite requested a review from bcardiff Sep 25, 2019
@bcardiff bcardiff merged commit 6128faa into master Sep 25, 2019
6 checks passed
6 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bcardiff added a commit that referenced this pull request Sep 27, 2019
Compiler: use virtual type for `uninitialized`
@straight-shoota straight-shoota deleted the bug/pointerof-virtual branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.