Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser crash for 'alias Foo?' #8282

Merged
merged 2 commits into from Oct 8, 2019
Merged

Fix parser crash for 'alias Foo?' #8282

merged 2 commits into from Oct 8, 2019

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Oct 6, 2019

cast from Crystal::Generic to Crystal::Path failed

(found by fuzzing)

Also make all parse_ident() calls more consistent

@oprypin
Fix parser crash for 'alias Foo?'
a9df38d 
> cast from Crystal::Generic to Crystal::Path failed
asterite
asterite reviewed Oct 7, 2019
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I added a suggestion for a refactor so that there isn't a lot of duplication.

src/compiler/crystal/syntax/parser.cr Outdated Show resolved Hide resolved
@oprypin
Refactor common parse_ident() calls as parse_path()
e558b2d 
for more consistent error checking.
@bcardiff bcardiff added this to the 0.32.0 milestone Oct 8, 2019
@bcardiff bcardiff merged commit b40ad4d into crystal-lang:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler:parser
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oprypin @asterite @bcardiff