Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for comma separators in enums and other cleanups #8657

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Jan 7, 2020

@straight-shoota
Copy link
Member

straight-shoota commented Jan 7, 2020

Shouldn't removal of compiler support for cast and usage in stdlib be in separate releases? Otherwise 0.33.0 compiler won't be able to compile 0.32.1 stdlib.

@bcardiff
Copy link
Member Author

bcardiff commented Jan 7, 2020

0.32.1 has both primitives, this is the required step to keep things moving forward.

The source of 0.33.0 after this PR uses convert and no longer uses :cast. Hence there is no future need to support :cast

@RX14
Copy link
Contributor

RX14 commented Jan 7, 2020

We really should make PRs/issues for removing things we deprecate and attach them to future milestones ahead of time so we don't forget

@bcardiff
Copy link
Member Author

bcardiff commented Jan 7, 2020

They will always be subject to be outdated when the time comes.

I would use a next/pinned milestone or even a future version milestone created ahead of time to flag those PRs. Yet they would be an intention, but not a hard commitment to be included in that release.

@straight-shoota
Copy link
Member

I don't think scheduling this is really important. Whether we remove a deprecated feature in the scheduled release or a few later doesn't make a huge difference. If all, delayed removal gives developers more time to update their code.

Having such collective cleanups from time to time seems perfectly fine to me.

@straight-shoota straight-shoota merged commit d0de305 into crystal-lang:master Jan 7, 2020
@straight-shoota
Copy link
Member

Thanks @bcardiff ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants