Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception in case of wrongly normalized target triple #8710

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Raise exception in case of wrongly normalized target triple #8710

merged 1 commit into from
Jan 29, 2020

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Jan 21, 2020

Fixes #8709

@Sija
Copy link
Contributor Author

Sija commented Jan 25, 2020

@RX14 ping

RX14
RX14 requested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

src/compiler/crystal/codegen/target.cr Outdated Show resolved Hide resolved
@Sija
Copy link
Contributor Author

Sija commented Jan 29, 2020

GTG?

@straight-shoota straight-shoota merged commit 4049ff7 into crystal-lang:master Jan 29, 2020
@straight-shoota straight-shoota added this to the 0.33.0 milestone Jan 29, 2020
@straight-shoota
Copy link
Member

Thanks @Sija

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

Index out of bounds with bad target on compile
4 participants
@Sija @straight-shoota @jhass @RX14