Compiler: fix inherited visibility of macro hooks #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
approved these changes
Feb 13, 2020
|
Nice spec :-). Great way to start the day. Thanks! |
Haha 😅 I wanted to reduce it but just in case I left it as is to be sure I'm fixing the actual issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8794
When expanding a macro we always pass a related ASTNode and were taking the visibility from it. The problem is, on macro hooks the node was the class definition, and if it was
privateit was taken from that which was wrong.To make the code simpler, now the macro expansion code requires an explicit visibility to be passed. Then in all places I made sure to pass the correct visibility. For macro hooks the initial visibility should always be
public.