Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All files shall have a descriptive file extension name. #8840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

postmodern
Copy link
Contributor

Generally a good practice and helps with Windows support.

* Generally a good practice and helps with Windows support.
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why people might reject this, but I think it's a good idea. It's relatively common practice to name the file just LICENSE without an extension, but naming the file with an extension is also popular. Even Github help states it's usually named LICENSE.txt or LICENSE.md (see https://help.github.com/en/github/creating-cloning-and-archiving-repositories/licensing-a-repository).

Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels different but I'm OK with it

@Sija
Copy link
Contributor

Sija commented Feb 23, 2020

If any, I'd use .md, since that's sth more usable these days than plain text.

@straight-shoota
Copy link
Member

On second thought: While I still agree with this change, I'd suggest not to merge it before reviewing other aspects of crystal init as well. I think it needs some love and further improvements.
I don't like to stall this, but it's also neither a huge change nor very important.

@HertzDevil HertzDevil added pr:needs-work A PR requires modifications by the author. topic:infrastructure topic:tools:init and removed topic:infrastructure labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:needs-work A PR requires modifications by the author. topic:tools:init
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants