Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Time::Span.new with positional + nanoseconds #8857

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

bcardiff
Copy link
Member

Fixes #8825

@straight-shoota
Copy link
Member

I don't follow why we need this to fix #8825. What's wrong with my suggestion from #8825 (comment) ?

I suppose we could still follow with this because nanoseconds is more likely to be passed as named parameter than other arguments. I'm not sure, but it might have even been a named-only argument at one point.

@bcardiff
Copy link
Member Author

bcardiff commented Mar 2, 2020

The idea was to use named argument for subseconds units since the nano/micro was not as obvious as the rest of the parts.

Some db drivers use the named argument so without this we are breaking that code without a deprecation cycle. People are forced to update in order to use nightly rather that noticing a deprecation warning on nightly.

@bcardiff bcardiff merged commit ff7113b into crystal-lang:master Mar 3, 2020
@bcardiff bcardiff deleted the fix/time-span branch March 4, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing (deprecated) definition for Time::Span
2 participants