Improve docs on Hash

[rdp]

Tweak Hash docs

[j8r]

To me it this information was quite obvious: Hash is ordered, as stated already in the object description.

Edit: sorry, I didn't see two different methods description were changed.

[rdp]

Yeah it is already fairly obvious, but the other methods called it out so I figured why not :)

[rdp]

I think this is ready for review again, thanks!

[rdp]

I think this is ready for review again, thanks!

[asterite]

I'm not convinced about the type annotation, but 🤷‍♂

[straight-shoota]

@asterite What do you mean regarding the type annotation?

[asterite]

I mean, you usually do hash.each { |k, v|, you don't specify a tuple there because the compiler will expand it. But if there's a type annotation then maybe un experienced users will specify a tuple as a block argument.

Just that feeling.

[straight-shoota]

Yeah, but we need that signature. Having no signature at all is obviously worse than a signature that could be misunderstood (but really don't lead to any errors).

& : K, V -> _ would techincally work, there shouldn't be a relevant difference (then remove the tuple from yield, obviously), but the tuple signature is required for implementing Enumerable#each(& T : ->). And it's also more correct. We're yielding items, and each item is a tuple of key and value.

[rdp]

I'll see if I can clarify it...

…

On Wed, Apr 8, 2020 at 9:42 AM Johannes Müller ***@***.***> wrote: Yeah, but we need that signature. Having no signature at all is obviously worse than a signature that could be misunderstood (but really don't lead to any errors). & : K, V -> _ would techincally work, there shouldn't be a relevant difference (then remove the tuple from yield, obviously), but the tuple signature is required for implementing Enumerable#each(& T : ->). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8887 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADBUHYKWTTY5IFH5W5LQLRLSLMRANCNFSM4LDKPPHA> .

[asterite]

There's no need to do anything else here. I'm just waiting on CI.

[rdp]

I think CI is stuck FWIW...

[straight-shoota]

CI is actually green, just the status hasn't updated.

[straight-shoota]

Thanks @rdp