Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename YAML::Builder.new with block to YAML::Builder.build #8896

Merged

Conversation

straight-shoota
Copy link
Member

The method is not a constructor and doesn't return an instance of YAML::Builder which I'd usually expect from a .new method.

Extracted from #8876 (comment)

@straight-shoota straight-shoota changed the title Rename YAML::Builder.new to YAML::Builder.build Rename YAML::Builder.new with block to YAML::Builder.build Mar 10, 2020
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RX14 RX14 added this to the 0.34.0 milestone Mar 16, 2020
@RX14 RX14 merged commit 6be2a4e into crystal-lang:master Mar 16, 2020
@straight-shoota straight-shoota deleted the refactor/yaml-builder-build branch March 16, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants