Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Location to HTTP::Request common header names #8992

Merged
merged 1 commit into from
Apr 2, 2020
Merged

add Location to HTTP::Request common header names #8992

merged 1 commit into from
Apr 2, 2020

Conversation

mamantoha
Copy link
Contributor

No description provided.

@mamantoha
Copy link
Contributor Author

mamantoha commented Apr 2, 2020 •
edited
Loading

"Location" header is used for redirects.
Mostly it used as "Location". But for example in GitHub response headers are all downcased.
I think it would be nice to have it.

@bcardiff bcardiff added this to the 0.34.0 milestone Apr 2, 2020
@bcardiff bcardiff merged commit 768c1ee into crystal-lang:master Apr 2, 2020
@mamantoha mamantoha deleted the add-location-to-common-header-names branch April 3, 2020 07:43
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Apr 29, 2020
@mamantoha @carlhoerberg
add Location to HTTP::Request common header names (crystal-lang#8992)
82c3e4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:networking
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mamantoha @bcardiff @RX14