Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Log handler for HTTP::Server #9034

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Add Log handler for HTTP::Server #9034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545af67
Add Log handler for HTTP::Server
straight-shoota Apr 9, 2020
789108f
Set log severity to error
straight-shoota Apr 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/http/server.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ require "./server/handler"
require "./server/response"
require "./server/request_processor"
require "./common"
require "log"
{% unless flag?(:without_openssl) %}
require "openssl"
{% end %}
Expand Down Expand Up @@ -128,6 +129,8 @@ require "./common"
# Reusing the connection also requires that the request body (if present) is
# entirely consumed in the handler chain. Otherwise the connection will be closed.
class HTTP::Server
Log = ::Log.for("http.server")

@sockets = [] of Socket::Server

# Returns `true` if this server is closed.
Expand Down Expand Up @@ -498,9 +501,12 @@ class HTTP::Server
@processor.process(io, io)
end

# This method handles exceptions raised at `Socket#accept?`.
private def handle_exception(e : Exception)
e.inspect_with_backtrace STDERR
STDERR.flush
# TODO: This needs more refinement. Not every exception is an actual server
# error and should be logged as such. Client malfunction should only be informational.
# See https://github.com/crystal-lang/crystal/pull/9034#discussion_r407038999
Log.error(exception: e) { "Error while connecting a new socket" }
end

# Builds all handlers as the middleware for `HTTP::Server`.
Expand Down