HTTP::Server: defer request upgrade (aka: WebSockets) #9243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a HTTP request is upgraded, the block is invoked synchronously, not returning from the handler and thus not allowing the request to be logged for example.
With this change, the handover is done right after the current request is finished. For example, if the
LogHandleris enabled, the protocol switch is logged right before the websocket starts, instead of when the websocket connection is finished.Also, because of this simplification, I was able to move the closing of the
IOto the caller of theRequestProcessor(theHTTP::Server). The upgrade handler is not responsible anymore of closing the socket.