Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flush methods to always flush underlying IO #9320

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Fix flush methods to always flush underlying IO #9320

merged 2 commits into from
Jun 1, 2020

Conversation

straight-shoota
Copy link
Member

It seems like a good idea to flush the underlying IO when flush is called on a wrapper.

#8891 (comment)

@straight-shoota straight-shoota mentioned this pull request May 19, 2020
Merged
@straight-shoota straight-shoota added this to the 0.35.0 milestone May 29, 2020
@bcardiff bcardiff merged commit bffe450 into crystal-lang:master Jun 1, 2020
@straight-shoota straight-shoota deleted the fix/io-flush-underlying branch June 1, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:files topic:stdlib:networking
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straight-shoota @jhass @bcardiff