Improve File.utime precision from second to 100-nanosecond on Windows #9344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
May 23, 2020
RX14
approved these changes
May 25, 2020
kubo
commented
May 28, 2020
kubo
force-pushed
the
improve-file-utime-precision-on-windows
branch
from
2bbf592
to
87b2600
Compare
RX14
approved these changes
May 31, 2020
straight-shoota
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
File.utimeis implemented by_wutime64whose time precision is second. The subsecond parts ofatimeandmtimeare zeroed.This PR uses
SetFileTimewhose time precision is 100-nanosecond.