Use Process.quote for crystal env output
#9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then we can use `eval "$(crystal env)"` in shell script safely.
jhass
approved these changes
Jun 5, 2020
|
Hmm, this change breaks |
straight-shoota
approved these changes
Jun 5, 2020
|
It will also break here I think https://github.com/crystal-lang/shards/blob/3859235dba7c166cdd5289677e6de4565617fc82/spec/support/factories.cr#L124 |
|
@bcardiff No. Because this PR doesn't change |
makenowjust
added a commit
to makenowjust/vscode-crystal-lang
that referenced
this pull request
Jun 6, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then we can use
eval "$(crystal env)"in shell script safely.