Use less strict cipher compatibility for OpenSSL client context #9459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Jun 11, 2020
|
@straight-shoota what are the default ciphers (if any) when the context is created? This change is probably the right way anyway, because it removes cipher suites already considered as "insecure" but I wonder if OpenSSL is not doing that already by default. |
|
I don't know. And it seems to be pretty hart to dive into this. IMO it's not worth considering because the defaults of openssl may change depending on the library version. And I think we should try to have the same default configuration for a Crystal program, regardless of the linked openssl version. |
|
Yes, agree 100% |
waj
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in https://forum.crystal-lang.org/t/http-client-connection-reset-by-peer/2226 this separates the default cipher compatibility level for OpenSSL contexts:
OpenSSL::SSL::Context::ClientusesOpenSSL::SSL::Context::CIPHERS_OLDOpenSSL::SSL::Context::ServerusesOpenSSL::SSL::Context::CIPHERS_INTERMEDIATEThis lets clients connect to servers which accept only weak ciphers, but a server only accepts relatively strong ciphers.