Revert IO#write changes in 0.35.0 and let it return Nil #9469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…written (crystal-lang#9233)" This reverts commit 7f13250.
|
I will throw some mentions and link to PRs that I am aware of that already migrate things to work with 0.35.0
Appologies for the back and forth with this api changes |
This was referenced Jun 15, 2020
waj
approved these changes
Jun 16, 2020
This was referenced Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9233 and #9363, yet keeps some cleanup, minor fixes and the return type of
IO.copyas Int64.You can read the motivations for reverting these changes at #9233 (comment)
Although is a breaking-change from 0.35.0, it's better to revert it now than make all the ecosystem adapt for the change in 0.35.0. That's why it's better to do it in 0.35.1.