Reject annotations on ivars defined in base class #9502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Jun 18, 2020
bcardiff
reviewed
Jul 1, 2020
Sija
reviewed
Jul 1, 2020
bcardiff
approved these changes
Jul 3, 2020
asterite
approved these changes
Jul 3, 2020
asterite
pushed a commit
to asterite/crystal-1
that referenced
this pull request
Jul 18, 2020
cmur2
added a commit
to spoved/crafana.cr
that referenced
this pull request
Jan 28, 2021
Due to crystal-lang/crystal#9502 this throws an error now compiling with Crystal 0.36.0: ``` In src/crafana/models/panels/graph.cr:32:5 32 | @[JSON::Field(key: "gridPos")] ^ Error: can't annotate @grid_pos in Crafana::Graph because it was first defined in Crafana::Panel ``` I'm not aware of any downsides of removing this duplicate definition.
cmur2
added a commit
to cmur2/crafana.cr
that referenced
this pull request
Jan 28, 2021
Due to crystal-lang/crystal#9502 this throws an error now compiling with Crystal 0.36.0: ``` In src/crafana/models/panels/graph.cr:32:5 32 | @[JSON::Field(key: "gridPos")] ^ Error: can't annotate @grid_pos in Crafana::Graph because it was first defined in Crafana::Panel ``` I'm not aware of any downsides of removing this duplicate definition.
kalinon
pushed a commit
to spoved/crafana.cr
that referenced
this pull request
Jan 30, 2021
Due to crystal-lang/crystal#9502 this throws an error now compiling with Crystal 0.36.0: ``` In src/crafana/models/panels/graph.cr:32:5 32 | @[JSON::Field(key: "gridPos")] ^ Error: can't annotate @grid_pos in Crafana::Graph because it was first defined in Crafana::Panel ``` I'm not aware of any downsides of removing this duplicate definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #9499
This raises an error instead of silently ignoring annotations on instance variables defined in a base class.