Compiler: try literal type in autocast first #9610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
reviewed
Jul 16, 2020
|
|
||
| it "doesn't autocast number on union (#8655)" do | ||
| run(%( | ||
| def foo(x : UInt8 | Int32, y : Float64) |
There was a problem hiding this comment.
If the union would have been UInt64 | Int64 and the call with Int32, what is the output?
ambiguous call? or any of those types are used?
There was a problem hiding this comment.
It says ambiguous call.
There was a problem hiding this comment.
ok, if there is no spec for that it should be added. Other than tat LGTM
bcardiff
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8655
When trying to match
Int32with autocasting enabled against a union type, we should always try to match first using the regular approach (check if Int32 matches any of the union types without autocasting) and then try to match using autocasting. The logic was reversed in the compiler so this fixes that.So before, the 255 literal, as an
Int32, vsUInt8 | Int32would match both types because of autocasting. Now it only matchesInt32exactly.