Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String#rindex default offset for matching empty regex correctly #9690

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Fix String#rindex default offset for matching empty regex correctly #9690

merged 1 commit into from
Aug 24, 2020

Conversation

makenowjust
Copy link
Contributor

Fixed #9679

@bcardiff bcardiff added this to the 1.0.0 milestone Aug 24, 2020
@bcardiff bcardiff merged commit f441298 into crystal-lang:master Aug 24, 2020
@makenowjust makenowjust deleted the string-rindex-empty branch August 24, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@oprypin oprypin oprypin approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:text
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

String#rindex(zero-width regex) doesn't match the end of the string
4 participants
@makenowjust @jhass @oprypin @bcardiff