Remove Enumerable#grep

[j8r]

The commit deprecating Enumerable#grep 7a86e8c date from 9 months, released in Crystal 0.32.0.

[asterite]

I still prefer grep over select for this (because of this)

[bcardiff]

I prefer filter over select 🙊

Since it was already marked as deprecated in 0.32:

• Either we allow select and grep to be alias (dropping the deprecated annotation)
• Or we drop grep at this point (as this PR does)

[j8r]

Agree, it is more an issue with #select, which can be ambiguous, than #grep, which is not ideal either (not a verb, nor on-par with the command).

[asterite]

I guess it's okay because it was deprecated...

[baweaver]

FYI: https://bugs.ruby-lang.org/issues/17140

Trying to get discussion on merging these two behaviors in Ruby itself.

[asterite]

@baweaver Cool! But what's { 'and', 'the', 'of' } in Ruby in your second example?

[baweaver]

Ah, right, sorry. It's a new Set literal in Ruby for 3.x: https://bugs.ruby-lang.org/issues/16989