Fix semantic version #9868
Merged
Fix semantic version #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Accept valid semantic versions like "1.2.3+foo.bar". - Reject invalid semantic versions like "1.2.3-foo." and a lot more that the parse were accepting.
jhass
approved these changes
Oct 31, 2020
bcardiff
approved these changes
Nov 4, 2020
|
@jhass is this really a breaking-change for you? It is a more strict validation, but within the original intended behavior. |
|
It has the potential to break existing projects using versions that don't parse by the more strict validation now, so yes, technically it is. It's a good change, I just felt the label is there to document such little gotchas. |
|
Ok 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexp used in the SemanticVersion class were accepting bad versions like
01.2.3and1.2.3-hey.and rejecting good versions like1.2.3+hey.ho.I just picked the regexp provided by https://semver.org/ itself and added few tests.