Deprecate TypeNode#has_attribute? and remove references to "attribute"

spec/compiler/parser/parser_doc_spec.cr

@@ -14,7 +14,7 @@ describe "Parser doc" do
     {"enum def", "enum Foo\nend"},
     {"constant assign", "A = 1"},
     {"alias", "alias Foo = Bar"},
-    {"attribute", "@[Some]"},
+    {"annotation", "@[Some]"},
     {"private def", "private def foo\nend"},
   ].each do |(desc, code)|
     it "includes doc for #{desc}" do

spec/compiler/semantic/annotation_spec.cr

@@ -892,7 +892,7 @@ describe "Semantic: annotation" do
         "funs can only be annotated with: NoInline, AlwaysInline, Naked, ReturnsTwice, Raises, CallConvention"
     end
 
-    it "doesn't carry link attribute from lib to fun" do
+    it "doesn't carry link annotation from lib to fun" do
       semantic(%(
         @[Link("foo")]
         lib LibFoo

spec/compiler/semantic/doc_spec.cr

@@ -107,7 +107,7 @@ describe "Semantic: doc" do
     bar.doc.should eq("Hello")
   end
 
-  it "stores doc for def with attribute" do
+  it "stores doc for def with annotation" do
     result = semantic %(
       class Foo
         # Hello
@@ -122,7 +122,7 @@ describe "Semantic: doc" do
     bar.doc.should eq("Hello")
   end
 
-  it "stores doc for def with attribute" do
+  it "stores doc for def with annotation" do
     result = semantic %(
       # Hello
       @[AlwaysInline]
@@ -238,8 +238,9 @@ describe "Semantic: doc" do
       end
     ), wants_doc: true
     program = result.program
+    ann = program.types["Flags"]
     foo = program.types["Foo"]
-    foo.has_attribute?("Flags").should be_true
+    foo.annotation(ann).should_not be_nil
     foo.doc.should eq("Hello")
     foo.locations.not_nil!.size.should eq(1)
   end

spec/compiler/semantic/enum_spec.cr

@@ -349,7 +349,8 @@ describe "Semantic: enum" do
       SomeFacts::AppleLover
       ))
     enum_type = result.program.types["SomeFacts"].as(EnumType)
-    enum_type.has_attribute?("Flags").should be_true
+    annotation_type = result.program.types["Flags"].as(AnnotationType)
+    enum_type.annotation(annotation_type).should_not be_nil
   end
 
   it "can use macro expression inside enum" do

spec/compiler/semantic/lib_spec.cr

@@ -366,7 +366,7 @@ describe "Semantic: lib" do
       "'lib' link argument must be a String"
   end
 
-  it "clears attributes after lib" do
+  it "clears annotations after lib" do
     assert_type(%(
       @[Link("foo")]
       lib LibFoo
@@ -494,7 +494,7 @@ describe "Semantic: lib" do
       "can't define method in lib LibC"
   end
 
-  it "reopens lib and adds more link attributes" do
+  it "reopens lib and adds more link annotations" do
     result = semantic(%(
       @[Link("SDL")]
       lib LibSDL
@@ -514,7 +514,7 @@ describe "Semantic: lib" do
     attrs[1].lib.should eq("SDLMain")
   end
 
-  it "reopens lib and adds same link attributes" do
+  it "reopens lib and adds same link annotations" do
     result = semantic(%(
       @[Link("SDL")]
       lib LibSDL
@@ -533,7 +533,7 @@ describe "Semantic: lib" do
     attrs[0].lib.should eq("SDL")
   end
 
-  it "gathers link attributes from macro expression" do
+  it "gathers link annotations from macro expression" do
     result = semantic(%(
       {% begin %}
         @[Link("SDL")]

src/compiler/crystal/macros.cr

@@ -1581,9 +1581,6 @@ module Crystal::Macros
   # class TypeOf < ASTNode
   # end
 
-  # class Attribute < ASTNode
-  # end
-
   # A macro expression,
   # surrounded by {{ ... }} (output = true)
   # or by {% ... %} (output = false)
@@ -1925,6 +1922,7 @@ module Crystal::Macros
     # Returns `true` if this type has an attribute. For example `@[Flags]`
     # or `@[Packed]` (the name you pass to this method is `"Flags"` or `"Packed"`
     # in these cases).
+    @[Deprecated("Use #annotation instead")]
     def has_attribute?(name : StringLiteral | SymbolLiteral) : BoolLiteral
     end
 

src/compiler/crystal/macros/interpreter.cr

@@ -371,7 +371,7 @@ module Crystal
         named_args = node.named_args.try &.to_h { |arg| {arg.name, accept arg.value} }
 
         begin
-          @last = receiver.interpret(node.name, args, named_args, node.block, self)
+          @last = receiver.interpret(node.name, args, named_args, node.block, self, node.name_location)
         rescue ex : MacroRaiseException
           raise ex
         rescue ex : Crystal::Exception
@@ -518,13 +518,13 @@ module Crystal
 
     def visit(node : Splat)
       node.exp.accept self
-      @last = @last.interpret("splat", [] of ASTNode, nil, nil, self)
+      @last = @last.interpret("splat", [] of ASTNode, nil, nil, self, node.location)
       false
     end
 
     def visit(node : DoubleSplat)
       node.exp.accept self
-      @last = @last.interpret("double_splat", [] of ASTNode, nil, nil, self)
+      @last = @last.interpret("double_splat", [] of ASTNode, nil, nil, self, node.location)
       false
     end