Apply changes to redirection rules #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We better not forget to add |
matiasgarciaisaia
approved these changes
Jun 7, 2024
docs/aws-config.json
Outdated
Comment on lines
33
to
35
| { | ||
| "Condition": { | ||
| "KeyPrefixEquals": "api/latest/${CRYSTAL_VERSION}/" |
There was a problem hiding this comment.
I think we should be able to delete this rule now, since before getting api/latest/1.x.y, we'll be catched by the new api/1 rule - and sent to the 404 page.
|
Anything else missing in order to ship this?
On the one hand, I agree with this. On the other hand, I'd expect us to have got rid of this patchwork of rules by the time Crystal's v2. But then again, the patchwork works, so we could add support for v2 already. |
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Jun 14, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@fe82a34 This includes the following changes: * crystal-lang/distribution-scripts#312 * crystal-lang/distribution-scripts#315 * crystal-lang/distribution-scripts#314 * crystal-lang/distribution-scripts#284 * crystal-lang/distribution-scripts#283 * crystal-lang/distribution-scripts#282 * crystal-lang/distribution-scripts#313
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Jun 16, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@fe82a34 This includes the following changes: * crystal-lang/distribution-scripts#312 * crystal-lang/distribution-scripts#315 * crystal-lang/distribution-scripts#314 * crystal-lang/distribution-scripts#284 * crystal-lang/distribution-scripts#283 * crystal-lang/distribution-scripts#282 * crystal-lang/distribution-scripts#313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ make get-website-configuration | tail -n +2 | sed -e 's/1.12.2/${CRYSTAL_VERSION}/g' > aws-config.json