-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken for 0.23.1 #23
Comments
This URL assumes package version |
Just ran into this.. am working around it by using 0.23.0 for now, by creating a file |
We can either extract the correct I'd vote to drop the |
Hi there! It's effectively because of the released tar.gz name. The published 0.23.1 was the third build - there was a first build published in one of the issues, a second build shared internally that was plain wrong, and this last one that worked. I'm still not sure about The Way™ to handle this. If it's not that much work to simply extract the name from the URL, I'd love to do that for now. We have started discussing distribution channels (some beta channel vs a stable one) that will imply betas, release candidates, etc, so I think we should first define that, and then choose between a build version (like the But I think a suffix will be there for a while, at least. Any other thoughts? |
To unblock this we can create a fallback from -1 to -5 in case a 404 is reached |
The info is there, I just was wondering if it's worth having many builds per version, given the only reason that happens is because of packaging errors. Anyway, there's an "assets" collection in the json response that holds the exact name of each file we distribute. We can iterate that and look for |
Something I neglected to mention in the original bug report is that this error took my app down, because the buildpack didn't fail after the 404 - it tried to deploy the app without a compiler installed. Whatever the solution to the above, it's probably worth making sure that future filename changes / 404s don't take apps down with them. |
Please review #24 so we fix this 👍 |
Thanks! |
Since the release of 0.23.1 I'm getting this from the buildpack:
Something changed about the upstream filenames, perhaps?
The text was updated successfully, but these errors were encountered: