Add support for installing maintenance version #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beta-ziliani
approved these changes
Jul 3, 2023
oprypin
reviewed
Jul 4, 2023
oprypin
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crystalinput gets another mode: If the value starts withbranch:, the following part is interpreted as a branch name on the git repository and the installer looks for a maintenance build associated with that branch.Querying works the same way as for nightly builds (which is equivalent to
branch: master), so this patch only adaps input processing and make the branch name configurable.Also adds some error handling in places where I noticed some holes.
Resolves #28