Update Crystal dependency declaration in shards.yml to include Crystal >= 1.0.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
straight-shoota
approved these changes
Apr 6, 2021
bcardiff
reviewed
Apr 7, 2021
olbat
force-pushed
the
update-crystal-dependency-declaration-in-shards-yml
branch
from
e034e24
to
fef7604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects that are depending on this library cannot be built correctly because of an implicit dependency on Crystal <= 0.x in the shards.yml file. Test are not passing with Crystal 1.0.0 but the error make me think that they were already broken (see this CI build from this MR that updates the doc for example).