Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shards check should exit zero if no shards.lock exists and no dependencies are required #145

Closed
bacongobbler opened this issue Dec 23, 2016 · 1 comment
Labels

Comments

@bacongobbler
Copy link

bacongobbler commented Dec 23, 2016

Hey everyone! Just playing around with Crystal a bit and I'm starting to write a Heroku buildpack for Crystal. Just starting to get my feet wet with shards. Cool project!

Given a sample application such as https://github.com/fishworks/example-crystal with no external dependencies (just the standard library), I would expect that shards check would consider it a valid application given that shards install will not produce a shard.lock file. Is shards check the proper way to "lint" a project for correctness?

This was tested with crystal 0.20.1, installed via homebrew.

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Dec 23, 2016

Indeed. Thanks for reporting!

f-fr pushed a commit to f-fr/shards that referenced this issue Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants