-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local overrides (was: Shards Link) #152
Comments
Maybe use the |
The problem with the path resolver is that you need to run |
Huh? AFAIK |
@ysbaddaden Oh, I thought it didn't. I should have checked, sorry. |
What is the path resolver? |
Instead of using a dependencies:
my_shard_name:
path: /absolute/path/to/dependency |
got it. Thanks. |
Still not quite as nice as the link option, with link I don't have to remember to change by path before pushing live... Maybe I could add that to a deploy script.. |
Just tried using dependencies:
db:
github: crystal-lang/crystal-db
path: /data/programming/crystal-db/
pg:
github: will/crystal-pg
version: ~> 0.13.1 This links crystal-db from github like usual, whichever way I order the listings. |
In bundler this is done by local overrides. It was discussed a bit in #105. I do manual link in ./lib/shard_name. It is error prone but it has been working for me until now. |
@RX14 you can't have multiple resolvers for the same dependency. You must drop/comment the github line. |
@ysbaddaden Apparently i'm so used to keeping |
+1 for something like this, bundler's way seems most appropriate for us. Having a dirty shard.yml and paying attention to not accidentally committing it is just too much of a PITA. Additionally we obviously should fail hard and early if there's more than one resolver given. |
Very much 👍 to my mistake failing hard. |
@jhass the current solution ain't great. I never had the need for that, so I admit I didn't search much to address the issue. Maybe local overrides, so we could keep |
Anyone put more thought into this? This is definitely a feature that's missing. |
I haven't. I needed this the other day, and I simply changed Having a different, git ignored, source for dependencies, such as local overrides has always been confusing in my experience. |
To add another data point, I still feel the pain of this quite often. Updating a Gemfile and running I did notice that once, when I tried running shards from an EC2 instance located in the US, it was astonishingly quick. Is that is how it works for other people normally?? |
You can use |
This was resolved by #422 |
Npm, bower and other package manages have the concept of linking dependencies. This is useful when developing app dependencies. Allowing you to have two projects in different folders, then one is sym-linked into the libs folder of the other.
I think it'd be useful to have this in shards. What do you think?
The text was updated successfully, but these errors were encountered: