-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing "v1.0.0:shard.yml" #346
Comments
I noticed this error, too. The reason is that A quick fix is to pin the shard to a specific version. For example dependencies:
redis:
github: stefanwille/crystal-redis
version: 2.5.3 This avoids shards trying to read |
Shards could also assume no dependencies for a tag without |
I'm not sure whether this would necessarily create a conflict. But treating a tag as a shards version when the fundamental |
I find quite strange to just ignore the tags. We should at least provide a warning or error if that version is selected. These versions exist probably from pre-shards era and not used so often anyway. |
Sure, making it an error should be fine. I just meant it shouldn't be a version you can actually use. |
But why not just a warning? What's the critical issue we're trying to avoid? |
Okay let's be clear:
Btw. shardbox knows about 84 releases with missing `shard.yml`
|
Agree with the first point. For the second, I'm writing a fix to show a warning when the version gets selected, explicitly or with a version expression. I think Shards should be as annoying as possible until the problem gets fixed, but not introduce blocking issues unnecessary. Shardbox is becoming an essential tool for this project. I think I'm going to ask you access to that database or install an instance myself 😉 |
I should probably make database exports available. 👍 |
Hi there.
There is an issue with installing some shards after updating to Crystal 0.34.0.
Steps to reproduce:
crystal init lib test_redis
)shard.yml
shards
Output:
Previously it took the latest version from the master branch.
The text was updated successfully, but these errors were encountered: