Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when a shard version didn't contain a shard.yml #362

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

waj
Copy link
Member

@waj waj commented Apr 20, 2020

Versions without a spec will just be considered as if they don't have dependencies, but a warning will be printed if a shard is installed without a shard.yml.

For example, stefanwille/crystal-redis didn't have a shard.yml in the first versions. But it will now install without problems if latest versions are used:

$ shards install
Resolving dependencies
Installing redis (1.11.0)
Writing shard.lock

However, when a version without spec is selected it will print the warning:

$ shards install
Resolving dependencies
Shard "redis" version (1.0.1) doesn't have a shard.yml file
Installing redis (1.0.1)
Writing shard.lock

Fixes #346

@waj waj merged commit c20eac2 into crystal-lang:master Apr 20, 2020
@waj waj deleted the fix/missing-shard-yml branch April 20, 2020 20:12
@oprypin
Copy link
Member

oprypin commented Apr 29, 2020

Please make a release with this, people in chat are running into this regularly.

@bcardiff bcardiff added this to the v0.11.0 milestone May 27, 2020
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "v1.0.0:shard.yml"
4 participants