Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small check for bad shards #350

Closed
hugopl opened this issue Apr 10, 2020 · 1 comment
Closed

Add small check for bad shards #350

hugopl opened this issue Apr 10, 2020 · 1 comment

Comments

@hugopl
Copy link

hugopl commented Apr 10, 2020

If a shard has a git tag like v1.2.1, but the shards.yml in the repository says 1.2.0, shards build will always tell you to run shards update and you will end up blamming shards until notice it was a problem with the shard you were trying to use.

For sure this isn't a problem in shards itself, but such check is easy and a better message to the user would help a lot.

Not first time I ran into this "problem", a good error message would had saved some minutes.

@RX14
Copy link
Contributor

RX14 commented Apr 10, 2020

Already solved by #341.

@RX14 RX14 closed this as completed Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants