Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and test process #214

Closed
wants to merge 7 commits into from

Conversation

conradwt
Copy link

@conradwt conradwt commented Jun 24, 2018

This PR fixes the build and test process for macOS.

Enhancements

  • Fix: macOS install command doesn't have a -t option

  • added make rule to install dependent shards

OS Tested

macOS 10.14 Status

  • installed successfully

  • tests ran successfully

Ubuntu 18.04 Status

  • installed successfully

  • tests ran successfully

@conradwt conradwt changed the title Fix build osx Fix build and test process Jun 24, 2018
@conradwt conradwt force-pushed the fix-build-osx branch 2 times, most recently from 6306143 to 5473d16 Compare June 24, 2018 07:15
@ysbaddaden
Copy link
Contributor

Thanks, but the only change I will merge is the install -t removal.

  1. Please don't bump VERSION (mark the changelog as UNRELEASED);
  2. The bin/shards target shouln't be changed to shards otherwise it will always rebuild;
  3. Shards mustn't be installed on the system before running tests. Only integration tests need it and searched it the local bin folder.

@ysbaddaden ysbaddaden closed this Jun 24, 2018
@ysbaddaden ysbaddaden reopened this Jun 24, 2018
@ysbaddaden
Copy link
Contributor

I misread. Running bin/shards install manully once ain't much of an hassle to be capable to run tests, but it's a pain when developing to have it run each time, because it will try to update the remote git repository on each test run.

@conradwt
Copy link
Author

conradwt commented Jun 24, 2018

@ysbaddaden Should I mark the CHANGELOG as follows:

## v0.8.2 (UNRELEASED)

or

## v0.8.2 [UNRELEASED]

@conradwt
Copy link
Author

conradwt commented Jun 24, 2018

@ysbaddaden I'm in the process of building a Portfile for shards. Now, Travis CI is failing because
minitest isn't installed. Also, MacPorts will break as well because make test will be ran as part of the port build process. For now, I'll update the Travis CI to run tests as follows:

make install_shards test

This will give developers like yourself good testing experience when using make test and this will make Travis CI happy. I guess a longer term solution would be to use the default testing framework for Crystal. The Crystal Book mentions spec module.

@conradwt
Copy link
Author

@ysbaddaden Please let me know if there's anything else I need to do with this PR because I need to get this one published to complete work on the Amber MacPorts Portfile.

@ysbaddaden
Copy link
Contributor

Merged as 1d249fb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants