Lock file implementation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is requiring Crystal HEAD. |
|
|
||
| unless lock_file? | ||
| File.open(lock_file_path, "w") { |file| manager.to_lock(file) } | ||
| end |
There was a problem hiding this comment.
The install command must regenerate the lock file in case any new package was installed.
ysbaddaden
force-pushed
the
feature/lock-file
branch
2 times, most recently
from
1c9de2b
to
a100a01
Compare
ysbaddaden
force-pushed
the
feature/lock-file
branch
from
a100a01
to
00327ac
Compare
Closed
|
Sadly, custom groups are behaving badly with the lock file. Either we have to resolve everything, which means cloning every dependency (whatever group we want to install); or the lock file lists the shards for the selected groups only, which results in a bad lock file (somehow truncated). I think I'll remove the ability to have and select custom groups and keep the development group only, until we can figure out how to properly deal with it. |
|
Yeah, bundler can only do it since it can fetch the whole graph via rubygems.org's dependency API. |
The lock file now contains a `version:` key (set at 1.0 for now) and dependencies are listed under the `shard:` key, this in order to be more future-proof to changes.
ysbaddaden
force-pushed
the
feature/lock-file
branch
from
d02a1db
to
738c6f9
Compare
ysbaddaden
added a commit
that referenced
this pull request
Sep 11, 2015
Groups don't play well with the lock file. Trying to install custom groups broke the lock file that no longer contained some shards (eg: development) but would contain some others (eg: custom). Only the development group has been kept, along with the ability to not install this group, which can be useful when deploying an application to build in production. The lock file won't be generated or overwritten when the development group isn't installed, since it would have the same problem than described above. The `--without development` argument may be renamed `--production` in the future, and won't allow to add or remove dependencies. refs #27
Groups don't play well with the lock file. Trying to install custom groups broke the lock file that no longer contained some shards (eg: development) but would contain some others (eg: custom). Only the development group has been kept, along with the ability to not install this group using the `--production` flag, which can be useful when deploying an application to be built in production. The lock file won't be generated or overwritten in this case, and installation will fail if a dependency has been added but isn't in the lock file.
ysbaddaden
force-pushed
the
feature/lock-file
branch
from
738c6f9
to
3196804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--productionparameter to skip development dependenciescloses #12 #31