Use read_file macro instead using OS-dependent cat

[Sija]

SSIA

[ysbaddaden]

Looks good. Yet, CI is red. Maybe master got broken, but I'd like CI to be green before merging PR.

[Sija]

Sure, that's understandable, yet AFAICS it's an unrelated fail - it fails due to the changes related to displaying error messages.

[ysbaddaden]

Would you be so kind to provie a PR to fix it? That would highly appreciated!

[Sija]

@ysbaddaden Sure, np.

btw, seems like --no-color switch ain't working:

  1) Failure:

BuildCommandTest#test_reports_error_when_target_failed_to_compile [test/integration/build_test.cr:70]:

Expected "Syntax error" to match "I: Dependencies are satisfied\nI: Building: app\nE: Error target app failed to compile:\nIn \e[4msrc/cli.cr:1:8\e[0m\n\n\e[2m 1 | \e[0m\e[1ma = ......\e[0m\n            \e[32;1m^\e[0m\n\e[33;1mError: unexpected token: ...\e[0m\n\n"

[ysbaddaden]

No colors only affects shards (logs have no colors) not the crystal build command (errors now always have colors, despite not being a tty).

[ysbaddaden]

The cat call breaks at compile time if the VERSION file is missing. What happens with read_file macro?

[straight-shoota]

read_file fails as well.

[ysbaddaden]

Thank you!