Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace glob patterns in Makefile with find command #328

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

waj
Copy link
Member

@waj waj commented Mar 10, 2020

Currently the Makefile makes use of the ** wildcard. But that actually doesn't have any effect. I replaced that with find calls, that I hope are fully portable 馃

@waj waj merged commit 37ba55e into crystal-lang:master Mar 10, 2020
@waj waj deleted the fix/makefile-glob-patterns branch March 10, 2020 21:47
@ysbaddaden
Copy link
Contributor

ysbaddaden commented Mar 12, 2020

AFAIK the shell function is a GNU make extension and not portable.

And ** perfectly worked for me, so that's weird. Maybe it's related to the deeply nested lib/molinillo/src/molinillo directory structure.

@bcardiff bcardiff added this to the v0.10.0 milestone Mar 27, 2020
taylor pushed a commit to vulk/shards that referenced this pull request Aug 11, 2020
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants