-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally drop the usage of Errno in favor of File::Error #331
Conversation
Some |
For me all |
Let's not bother with conditionals: master will only compile against crystal master, which is fine IMO. |
If one needs a latest shards and an older crystal compiler, which is not that common, (s)he can use a statically linked shards, from the official archives or compile it. |
@waj feedback addressed.
|
Shards doesn't have to bootsrap itself from the previous crystal version, there's no need for it to compile on both. Shards has always been released in lockstep with Crystal and this has been fine in the past. |
Shards CI runs on latest, no master. That and the possibility of using a new shards version leads to the need for shards to compile on the latest released Crystal and not just nightly. I have restarted the osx failure. OSX travis build should go away and build on other provider. This PR can be merged and later we handle the story for specs on Crystal master. |
Rebased on master. No further changes done. I will refactor the logging on another PR. |
No description provided.