Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally drop the usage of Errno in favor of File::Error #331

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

bcardiff
Copy link
Member

No description provided.

@Sija
Copy link
Contributor

Sija commented Mar 11, 2020

Some TODO: remove after ... would be good to have.

@bcardiff
Copy link
Member Author

For me all compare_versions are subject to be removed eventually. They will go when the mentioned version is wanted to be dropped. That might not depend on the version of the main lib or app. So it's hard to say, to be removed after x.y.z.

@ysbaddaden
Copy link
Contributor

Let's not bother with conditionals: master will only compile against crystal master, which is fine IMO.

@j8r
Copy link
Contributor

j8r commented Mar 12, 2020

If one needs a latest shards and an older crystal compiler, which is not that common, (s)he can use a statically linked shards, from the official archives or compile it.

src/resolvers/path.cr Outdated Show resolved Hide resolved
src/package.cr Outdated Show resolved Hide resolved
@bcardiff
Copy link
Member Author

bcardiff commented Mar 12, 2020

@waj feedback addressed.

I forgot to send/mention that to test this on 0.34.0 we need an update & release of minitest ysbaddaden/minitest.cr#38

@RX14
Copy link
Contributor

RX14 commented Mar 17, 2020

Shards doesn't have to bootsrap itself from the previous crystal version, there's no need for it to compile on both.

Shards has always been released in lockstep with Crystal and this has been fine in the past.

@bcardiff
Copy link
Member Author

Shards CI runs on latest, no master. That and the possibility of using a new shards version leads to the need for shards to compile on the latest released Crystal and not just nightly.

I have restarted the osx failure. OSX travis build should go away and build on other provider.

This PR can be merged and later we handle the story for specs on Crystal master.

@bcardiff
Copy link
Member Author

Rebased on master. No further changes done.

I will refactor the logging on another PR.

@bcardiff bcardiff merged commit 2914512 into crystal-lang:master Mar 23, 2020
@bcardiff bcardiff deleted the fix/errno branch March 24, 2020 17:45
@bcardiff bcardiff added this to the v0.10.0 milestone Mar 27, 2020
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants